system prune: only warn for volumes if --volumes is given#255
Merged
mlaventure merged 1 commit intodocker:masterfrom Jun 29, 2017
Merged
system prune: only warn for volumes if --volumes is given#255mlaventure merged 1 commit intodocker:masterfrom
mlaventure merged 1 commit intodocker:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 46.84% 46.85% +<.01%
==========================================
Files 172 172
Lines 11692 11692
==========================================
+ Hits 5477 5478 +1
+ Misses 5903 5902 -1
Partials 312 312 |
Contributor
|
I know it's only for 2 lines, but I think a text template would be cleaner. Something like: https://play.golang.org/p/nLs0YvRrRE |
albers
force-pushed
the
system-prune-volume-warning
branch
2 times, most recently
from
ca71856 to
6e89c02
Compare
Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
system-prune-volume-warning
branch
from
6e89c02 to
849b0e9
Compare
Collaborator
Author
|
@mlaventure Thanks for your advice and the code sample. I pulled out message generation into a function that uses a template. PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#118 changed
docker system pruneto only remove volumes if--volumesis given.The warning message, however, still always warns about volume removal:
The warning message in the above example is wrong: no volumes will be deleted.
With this PR, the volume removal warning is included selectively depending on whether
--volumesis given or not.