[pretty print] pretty print and healthcheck#1732
Merged
vdemeester merged 2 commits intodocker:masterfrom Mar 19, 2019
Merged
Conversation
fixes docker#117 Print healthcheck information in pretty mode. Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
==========================================
+ Coverage 56.14% 56.14% +<.01%
==========================================
Files 306 306
Lines 21033 21035 +2
==========================================
+ Hits 11809 11811 +2
Misses 8369 8369
Partials 855 855 |
thaJeztah
requested changes
Mar 19, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
one small nit, but otherwise looks good
ping @vdemeester ptal
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
silvin-lubecki
approved these changes
Mar 19, 2019
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
LGTM, thank you @sjeandeaux 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #117
Print healthcheck information in pretty mode.
Signed-off-by: Stephane Jeandeaux stephane.jeandeaux@gmail.com
- What I did
The pretty print prints the healthcheck information.
- How I did it
The pretty template is modified.
- How to verify it
The unit test is modified to test if healthcheck is there.
- Description for the changelog