X Tutup
Skip to content

[18.06] Added events filter scope for bash and zsh completion#1229

Merged
thaJeztah merged 2 commits intodocker:18.06from
thaJeztah:18.06-backport-completion
Aug 3, 2018
Merged

[18.06] Added events filter scope for bash and zsh completion#1229
thaJeztah merged 2 commits intodocker:18.06from
thaJeztah:18.06-backport-completion

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 23, 2018

cherry-pick of #1227 for 18.06

git checkout -b 18.06-backport-completion upstream/18.06
git cherry-pick -s -S -x c922ea2f453d2c2b1f4f1f805e0288cfd72aee8d
git cherry-pick -s -S -x 13db1bc95fc7815b918f34f14b5105110d25881a
git push -u origin

cherry-pick was clean, no conflicts

@pszczekutowicz @thaJeztah
Added events filter scope bash completion
4e6dbe6 
Signed-off-by: Paweł Szczekutowicz <pszczekutowicz@gmail.com>
(cherry picked from commit c922ea2)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@pszczekutowicz @thaJeztah
Added events filter scope zsh completion
ddad2f5 
Signed-off-by: Paweł Szczekutowicz <pszczekutowicz@gmail.com>
(cherry picked from commit 13db1bc)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from albers as a code owner July 23, 2018 09:47
@thaJeztah

This comment has been minimized.

Sign in to view
@thaJeztah thaJeztah added this to the 18.06.1 milestone Jul 23, 2018
albers
albers approved these changes Jul 23, 2018
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Jul 23, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

silvin-lubecki
silvin-lubecki approved these changes Jul 23, 2018
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit c2fa773 into docker:18.06 Aug 3, 2018
@thaJeztah thaJeztah deleted the 18.06-backport-completion branch August 3, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@albers albers albers approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees

No one assigned

Labels

area/completion status/2-code-review

Projects

None yet

Milestone

18.06.1

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah @vdemeester @albers @silvin-lubecki @GordonTheTurtle @pszczekutowicz
X Tutup