Added support for --quiet flag on docker push#1220
Closed
justyntemme wants to merge 3 commits intodocker:masterfrom
justyntemme:master
Closed
Added support for --quiet flag on docker push#1220justyntemme wants to merge 3 commits intodocker:masterfrom justyntemme:master
justyntemme wants to merge 3 commits intodocker:masterfrom
justyntemme:master
Conversation
Contributor
Author
|
Will fix lint within the hour. |
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:justyntemme/cli.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354290488
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
test to show current behavior is wrong at parsing an environment file
defining an undefined variable - it must not be defined!
NOTE: this test assume the $HOME variable is always set (see POSIX, this
normally is the case, e.g. the test suite remains stable).
Signed-off-by: Tom Klingenberg <tklingenberg@lastflood.net>
previously docker did import environment variables if they were present but created them if they were not when it was asked via a --env-file cli option to import but not create them. fix is to only import the variable into the environment if it is present. additionally do not import variable names of zero-length (which are lines w/ a potential variable definition w/o a variable name). refs: - docker/for-linux#284 Signed-off-by: Tom Klingenberg <tklingenberg@lastflood.net>
Signed-off-by: Justyn Temme <justyntemme@gmail.com>
Member
|
continued in #1221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justyn Temme justyntemme@gmail.com
- What I did
Added --quiet flag for docker push
Fix for #958
- How I did it
Passing a flag to either write out the content body of the response, or simply output nothing
- How to verify it
docker push --quiet tagged/image
- Description for the changelog
Added a --quiet flag for docker push
- A picture of a cute animal (not mandatory but encouraged)