[18.06] backport credential-helper fixes#1184
Merged
silvin-lubecki merged 2 commits intodocker:18.06from Jul 5, 2018
Merged
Conversation
This is mainly for the `pass` helper ; `pass` shouldn't be called every docker command anymore ;). Signed-off-by: Vincent Demeester <vincent@sbr.pm> (cherry picked from commit d9741fc) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
'CheckInitialized' in the credential-helper library actually invokes `pass`, which isn't desirable (see docker#699). This moves the check to be simpler, and then pass will only be invoked when it's needed (such as for `docker login` or when pulling from a private registry). This logic could also reasonably live in the credential-helper library, but it's simple enough it seems fine in either location. Signed-off-by: Euan Kemp <euank@euank.com> (cherry picked from commit 056015c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick for 18.06 of;
Resolves #699
no conflicts, cherry-pick was clean
ping @euank @vdemeester @n4ss PTAL