Fix service filtering by name on Kubernetes#1101
Merged
vdemeester merged 1 commit intodocker:masterfrom Jun 1, 2018
Merged
Conversation
silvin-lubecki
force-pushed
the
filter-stack-service
branch
from
46ebc27 to
f91df41
Compare
thaJeztah
added
status/2-code-review
area/stack
area/kubernetes
and removed
status/0-triage
labels
thaJeztah
reviewed
May 31, 2018
| } | ||
|
|
||
| func filterServicesByName(services []swarm.Service, f filters.Args, stackName string) []swarm.Service { | ||
| names := f.Get("name") |
Member
There was a problem hiding this comment.
Would it be clearer to pass names []string as argument instead of the filter-set?
mat007
approved these changes
Jun 1, 2018
vdemeester
requested changes
Jun 1, 2018
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
SGTM with @thaJeztah's comment taken care of :)
* Kubernetes native filtering (server side) is an exact match, now filtering on name is made client-side to add prefix-matching Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubecki
force-pushed
the
filter-stack-service
branch
from
f91df41 to
b1ff199
Compare
Contributor
Author
|
PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix #1092 by filtering services by name but client side.
- How to verify it
- Description for the changelog
Fix #1092 filtering stack service name by prefix
- A picture of a cute animal (not mandatory but encouraged)
