X Tutup
Skip to content

Document reserved namespaces deprecation#1040

Merged
thaJeztah merged 1 commit intodocker:masterfrom
cyli:deprecated-engine-labels
May 16, 2018
Merged

Document reserved namespaces deprecation#1040
thaJeztah merged 1 commit intodocker:masterfrom
cyli:deprecated-engine-labels

Conversation

@cyli
Copy link
Contributor

@cyli cyli commented May 7, 2018

Document that reserved namespaces org.docker., io.docker., and org.dockerproject.* in engine labels are now deprecated.

See moby/moby#36921

cc @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments on the versions 😅


### Reserved namespaces in engine labels

**Deprecated in Release: v18.05.0**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was merged after 18.05 was cut, so can you update this to 18.06?

The deprecation policy states we use 3 stable releases (https://docs.docker.com/engine/#installation-guides), so it should become an error in 18.12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, so sorry for the delay! Thanks!

org.dockerproject.* in engine labels are now deprecated.

Signed-off-by: Ying Li <ying.li@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 96dba79 into docker:master May 16, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.06.0 milestone May 16, 2018
@cyli cyli deleted the deprecated-engine-labels branch May 16, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup