Document reserved namespaces deprecation#1040
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 16, 2018
cyli:deprecated-engine-labels
Merged
Document reserved namespaces deprecation#1040thaJeztah merged 1 commit intodocker:masterfrom cyli:deprecated-engine-labels
thaJeztah merged 1 commit intodocker:masterfrom
cyli:deprecated-engine-labels
Conversation
thaJeztah
requested changes
May 9, 2018
Member
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Left some comments on the versions 😅
docs/deprecated.md
Outdated
|
|
||
| ### Reserved namespaces in engine labels | ||
|
|
||
| **Deprecated in Release: v18.05.0** |
Member
There was a problem hiding this comment.
Looks like it was merged after 18.05 was cut, so can you update this to 18.06?
The deprecation policy states we use 3 stable releases (https://docs.docker.com/engine/#installation-guides), so it should become an error in 18.12
Contributor
Author
There was a problem hiding this comment.
Done, so sorry for the delay! Thanks!
org.dockerproject.* in engine labels are now deprecated. Signed-off-by: Ying Li <ying.li@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that reserved namespaces org.docker., io.docker., and org.dockerproject.* in engine labels are now deprecated.
See moby/moby#36921
cc @thaJeztah