Update Attach, Build, Commit, Cp, Create subcommand fish completions by eiais · Pull Request #1005 · docker/cli

eiais · 2018-04-15T02:51:04Z

continuing on #977.
Two things I noticed while doing this:
Docker build --target is the only option description that has a period
Docker cp --follow-link description should probably say symbolic links not symbol link

thaJeztah

Thank you! This is great!

I noticed some minor issues, and left suggestions for follow ups: if you can amend those commits 🤗

thaJeztah · 2018-04-20T16:32:45Z

contrib/completion/fish/docker.fish

 complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l help -d 'Print usage'
 complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l no-stdin -d 'Do not attach STDIN'
-complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l sig-proxy -d 'Proxy all received signals to the process (non-TTY mode only). SIGCHLD, SIGKILL, and SIGSTOP are not proxied.'
+complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l sig-proxy -d '  Proxy all received signals to the process'


There's some leading whitespace in the description (' Proxy all..)

thaJeztah · 2018-04-20T16:36:27Z

contrib/completion/fish/docker.fish

 complete -c docker -f -n '__fish_docker_no_subcommand' -a cp -d "Copy files/folders between a container and the local filesystem"
+complete -c docker -A -f -n '__fish_seen_subcommand_from cp' -s a -l archive -d 'Archive mode (copy all uid/gid information)'
+complete -c docker -A -f -n '__fish_seen_subcommand_from cp' -s L -l follow-link -d 'Always follow symbol link in SRC_PATH
+'


Looks like there's a line-break before the closing quote

thaJeztah · 2018-04-20T16:38:54Z

contrib/completion/fish/docker.fish

+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -s v -l volume -d 'Bind mount a volume'
 complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l volumes-from -d 'Mount volumes from the specified container(s)'
 complete -c docker -A -f -n '__fish_seen_subcommand_from create' -s w -l workdir -d 'Working directory inside the container'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l blkio-weight -d 'Block IO (relative weight), between 10 and 1000, or 0 to disable (default 0)'


Wondering why all these moved to the end, and not in alphabetical order 😅

thaJeztah · 2018-04-20T16:39:22Z

contrib/completion/fish/docker.fish

 complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l cap-add -d 'Add Linux capabilities'
 complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l cap-drop -d 'Drop Linux capabilities'
 complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l cidfile -d 'Write the container ID to the file'
-complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l cpuset -d 'CPUs in which to allow execution (0-3, 0,1)'


See question below on alphabetical order 🤗

thaJeztah · 2018-04-20T16:40:08Z

contrib/completion/fish/docker.fish

 complete -c docker -A -f -n '__fish_seen_subcommand_from create' -s t -l tty -d 'Allocate a pseudo-TTY'
-complete -c docker -A -f -n '__fish_seen_subcommand_from create' -s u -l user -d 'Username or UID'
-complete -c docker -A -f -n '__fish_seen_subcommand_from create' -s v -l volume -d 'Bind mount a volume (e.g., from the host: -v /host:/container, from Docker: -v /container)'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -s u -l user -d '  Username or UID (format: <name|uid>[:<group|gid>])'


Leading whitespace in the description (' Username ....)

thaJeztah · 2018-04-20T16:44:33Z

contrib/completion/fish/docker.fish

+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l userns -d 'User namespace to use'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l uts -d 'UTS namespace to use'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l volume-driver -d 'Optional volume driver for the container'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l volumes--from -d 'Mount volumes from the specified container(s)'


Hm. Not for this PR, but we should change the description, and remove the (s) from container(s); while you can specify the --volumes-from option multiple times, each flag only accepts a single container.

Perhaps we should also have a look at the Mount volumes from ..., because those volumes aren't really "owned" by a container; --volumes-from merely copies the volume settings (source, dest) from the specified containers.

thaJeztah · 2018-04-20T16:47:14Z

contrib/completion/fish/docker.fish

+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l sysctl -d 'Sysctl options'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l tmpfs -d 'Mount a tmpfs directory'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l ulimit -d 'Ulimit options'
+complete -c docker -A -f -n '__fish_seen_subcommand_from create' -l userns -d 'User namespace to use'


Also not for this PR, but this option may need a better description (perhaps mentioning valid values)

Signed-off-by: Kyle Spiers <kyle@spiers.me>

eiais · 2018-04-26T04:11:39Z

@thaJeztah This should be good to go.

thaJeztah

LGTM, thank you!

thaJeztah · 2018-04-26T11:54:13Z

contrib/completion/fish/docker.fish

+complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l detach-keys -d 'Override the key sequence for detaching a container'
 complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l help -d 'Print usage'
 complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l no-stdin -d 'Do not attach STDIN'
-complete -c docker -A -f -n '__fish_seen_subcommand_from attach' -l sig-proxy -d 'Proxy all received signals to the process (non-TTY mode only). SIGCHLD, SIGKILL, and SIGSTOP are not proxied.'


Perhaps (follow-up) we should add the extra information back to the actual flag description (sounds useful information);

(non-TTY mode only). SIGCHLD, SIGKILL, and SIGSTOP are not proxied.

thaJeztah · 2018-04-26T11:58:33Z

ping @vdemeester @silvin-lubecki PTAL

thaJeztah · 2018-05-02T19:26:22Z

ping @vdemeester PTAL

vdemeester

LGTM 🐯

GordonTheTurtle added the status/0-triage label Apr 15, 2018

thaJeztah added status/2-code-review and removed status/0-triage labels Apr 20, 2018

thaJeztah requested changes Apr 20, 2018

View reviewed changes

thaJeztah added the process/cherry-pick label Apr 20, 2018

eiais and others added 5 commits April 20, 2018 11:48

update docker Attach subcommand fish completions

ee5aad8

Signed-off-by: Kyle Spiers <kyle@spiers.me>

update docker Build subcommand fish completions

44168f5

Signed-off-by: Kyle Spiers <kyle@spiers.me>

update docker Commit subcommand fish completions

67a80e3

Signed-off-by: Kyle Spiers <kyle@spiers.me>

update docker Cp subcommand fish completions

49d8604

Signed-off-by: Kyle Spiers <kyle@spiers.me>

update docker Create subcommand fish completions

b491ad1

Signed-off-by: Kyle Spiers <kyle@spiers.me>

thaJeztah approved these changes Apr 26, 2018

View reviewed changes

vdemeester approved these changes May 3, 2018

View reviewed changes

vdemeester merged commit e956159 into docker:master May 3, 2018

GordonTheTurtle added this to the 18.06.0 milestone May 3, 2018

eiais mentioned this pull request May 15, 2018

Update Events, Exec, Export, History, Images, Import, Inspect, Load, and Login subcommand fish completions #1061

Merged

thaJeztah added area/completion and removed process/cherry-pick labels Aug 3, 2018

Conversation

eiais commented Apr 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eiais commented Apr 26, 2018

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Apr 26, 2018

Uh oh!

thaJeztah commented May 2, 2018

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eiais commented Apr 15, 2018 •

edited

Loading