[Docker proposal branch] Using one-line commands#2
Open
racterub wants to merge 2 commits intodiraol:docker_proposalfrom
racterub:docker_proposal
Open
[Docker proposal branch] Using one-line commands#2racterub wants to merge 2 commits intodiraol:docker_proposalfrom racterub:docker_proposal
racterub wants to merge 2 commits intodiraol:docker_proposalfrom
racterub:docker_proposal
Conversation
Now we can propperly test python-mode in an environment with a very well defined python version and a vim built/compiled for this specific version as well. The best way is to use the `build_docker_images.sh` file in order to create the docker image with all python versions you desire. Also, in order to run the container you just have to do: docker run --rm -it python-mode:<version> Related to python-mode#977
Owner
|
Hi @racterub Thanks for the PR! Actually, the problem was just with line 43. There was an extra For maintenance purposes I think I prefer each command in a line (and it is ok, there is no warning with that!). I've pushed the change. Can you try to see if the warning is still there? Thanks! |
Author
|
If you mean docker, it works fine 😄 |
Author
|
And, I'm thinking of putting a script on image for faster testing 😕 root@847d2ab482e4:~# cat test.sh
#!/bin/bash
cd ~/.vim/pack/foo/start/python-mode
find . -type f -name '*.pyc' -delete && find . -type d -name '__pycache__' -delete
vim -i NONE -u debugvimrc.vim ~/test.py |
Owner
Great!
Sure man! Go ahead! Any improvement is very welcome! |
diraol
force-pushed
the
docker_proposal
branch
from
d5ff4c0 to
fdd4d26
Compare
diraol
force-pushed
the
docker_proposal
branch
from
fdd4d26 to
bea1104
Compare
diraol
force-pushed
the
docker_proposal
branch
3 times, most recently
from
636ff34 to
e685f74
Compare
diraol
force-pushed
the
docker_proposal
branch
3 times, most recently
from
38ca89e to
e7ccf5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With current commit 3505579, Docker will trigger error "Empty continuation lines will become errors in a future release." and stop building.
code:
python-mode/Dockerfile
Lines 23 to 28 in 3505579
python-mode/Dockerfile
Lines 36 to 43 in 3505579
With my commit, everything works fine.