X Tutup
Skip to content

chore: fix CI badge in README.rst#195

Merged
sbillinge merged 1 commit intodiffpy:mainfrom
stevenhua0320:CI-badge-fix
Mar 29, 2026
Merged

chore: fix CI badge in README.rst#195
sbillinge merged 1 commit intodiffpy:mainfrom
stevenhua0320:CI-badge-fix

Conversation

@stevenhua0320
Copy link
Copy Markdown
Contributor

@sbillinge ready to review. Note that because in the new skpkg workflow we changed the name of the yaml file that related to CI, so now with the previous link in the README.rst the CI badge could not show up. Now we change to the correct workflow and should show up.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (acbcd85) to head (c5659e9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          15       15           
  Lines        2507     2507           
=======================================
  Hits         2487     2487           
  Misses         20       20           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit 8935b1f into diffpy:main Mar 29, 2026
7 checks passed
@sbillinge
Copy link
Copy Markdown
Contributor

Thanks for catching that @stevenhua0320 . That should have been catched by scikit-package. Please can you check that the scikit-package template is correct and make an issue if not? Thanks.

@stevenhua0320
Copy link
Copy Markdown
Contributor Author

stevenhua0320 commented Mar 29, 2026

@sbillinge Now I checked with the scikit-package repo and found that in the new convention of scikit-package we named the file as matrix-and-codecov-on-merge-to-main.yml. But in the previous workflow we name the diffpy.structure with matrix-and-codecov.yml, and in the package update command, since the materials in the file is the same, so it didn't change anything. But this arises the problem of inconsistency of workflow and the README.rst. Therefore, I don't think we need any edits there, but need to consider whether we need to rename the workflow file here and change it back to the original link at the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup