Fix race conditions writing snapshots when junit.jupiter.execution.parallel.enabled is true#534
Conversation
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Fantastic contribution, thanks very much!
Can you update the changelog under ## Unreleased https://github.com/diffplug/selfie/blob/main/jvm/CHANGELOG.md. Maybe something like this:
### Fixed
- snapshots created by `junit.jupiter.api.TestFactory` are no longer garbage-collected (#534)
- support parallel testing under `junit.jupiter.execution.parallel.enabled=true` (#534)
I'll merge and release pronto.
jvm/selfie-runner-junit5/src/main/kotlin/com/diffplug/selfie/junit5/SnapshotSystemJUnit5.kt
Outdated
Show resolved
Hide resolved
nathanregner
force-pushed
the
junit5-parallelism
branch
from
e7231d1 to
0878682
Compare
Thank you for the fantastic library! Done! |
nathanregner
force-pushed
the
junit5-parallelism
branch
from
0878682 to
19ea542
Compare
…ions are present
…arallel.enabled` is true
nathanregner
force-pushed
the
junit5-parallelism
branch
from
19ea542 to
99852ac
Compare
|
For future reference, I prefer revisions to get pushed up as new commits rather than force-pushing over old ones. Easier to review just the incremental change rather than the whole thing over. Once it gets pushed up I'd rather the history be "honest" to the conversation from there rather than clean. |
2 participants
No description provided.