Afterglow: make selected text colors more visible#22
Afterglow: make selected text colors more visible#22jackbravo wants to merge 1 commit intodexpota:masterfrom
Conversation
dexpota
left a comment
dexpota
left a comment
There was a problem hiding this comment.
Thank you for your contribution, your change of color scheme for the selection is for sure an improvement. I am sorry for the delay in the review.
During the review, I took a look at the original theme and now I have noticed that some values are not the same. I didn't check all values but now I am worried that this theme is nothing like the original. I am going to take some time and check if maybe this theme is one of the variations (Afterglow blue, Afterglow magenta, ...)
| foreground #d0d0d0 | ||
| cursor #d0d0d0 | ||
| selection_background #303030 | ||
| selection_background #eecb8b |
There was a problem hiding this comment.
From the original theme design, I can see that the color for selection background is #5A647E (see here)
| color7 #d0d0d0 | ||
| color15 #f5f5f5 | ||
| selection_foreground #202020 | ||
| selection_foreground #232323 |
There was a problem hiding this comment.
The original theme doesn't define a color for the foreground selection, in this case, I think that Sublime defaults to the foreground color for unselected text.
2 participants
Without change:
With change:
assignees: dexpota