Types - Add undefined for EmblaPluginsType members.#1293
Open
tetarchus wants to merge 2 commits intodavidjerleke:masterfrom
Open
Types - Add undefined for EmblaPluginsType members.#1293tetarchus wants to merge 2 commits intodavidjerleke:masterfrom
undefined for EmblaPluginsType members.#1293tetarchus wants to merge 2 commits intodavidjerleke:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
undefinedto plugins returned by theapi.plugins()function.This ensures that the types are more accurate as a typescript will currently list a plugin as a definite value returned by the
plugins()function if its module is imported (due to interface merging), however if it is not passed to the embla carousel, it will fail at runtime due to that plugin not being loaded.The documentation for calling functions on the plugin uses optional chaining to get around this, however lint rules such as
@typescript-eslint/no-unnecessary-conditionwill flag this as not required, and typescript will not alert that this is required - this change will resolve both issues and bring the types in-line with suggested usage to allow editor hints.