Conversation
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 65 65
Lines 1586 1586
Branches 280 280
=======================================
Hits 1476 1476
Misses 46 46
Partials 64 64 ☔ View full report in Codecov by Sentry. |
kravets-levko
requested review from
andrefurlan-db,
arikfr,
benc-db,
jackyhu-db,
rcypher-databricks,
superdupershant and
yunbodeng-db
as code owners
| @@ -1,22 +0,0 @@ | |||
| const fs = require('fs'); | |||
There was a problem hiding this comment.
We do not have ts counterpart for this?
There was a problem hiding this comment.
I removed it because we don't really need custom logging in tests
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
|
|
||
| const result = await resultHandler.fetchNext({ limit: rowsCount }); | ||
|
|
||
| // @ts-expect-error TS2339: Property _data does not exist on type IOperation |
There was a problem hiding this comment.
Are you planning any additional PRs to resolve these type incompatibilities? I assume these comments are like compiler directives saying that we know this property is not part of the type def?
There was a problem hiding this comment.
Yes, you're totally correct. Fields marked as private in TS become a regular public fields in JS. And in tests we used this quite a lot to inspect internal state of objects. When convering to TS, I fixed what was easy to fix, and added these @ts-expect-error directives for non-trivial ones. After we have all the tests in TS, I'll do another iteration and hopefully clean these up
4 participants
Part of PECO-1390