[PECO-1390] Configure Typescript for tests#256
Merged
kravets-levko merged 2 commits intomainfrom Apr 29, 2024
Merged
Conversation
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
requested review from
andrefurlan-db,
arikfr,
benc-db,
jackyhu-db,
rcypher-databricks,
superdupershant and
yunbodeng-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
force-pushed
the
typescript-for-tests
branch
from
fe019c5 to
4180896
Compare
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 92.68% 92.56% -0.12%
==========================================
Files 64 65 +1
Lines 1545 1547 +2
Branches 273 273
==========================================
Hits 1432 1432
- Misses 47 49 +2
Partials 66 66 ☔ View full report in Codecov by Sentry. |
benc-db
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PECO-1390
nycto run tests viats-node;/libinstead of/distsonyccan properly collect coverage data. A great side-effect of this - no longer need to build sources before runing tests;.jsfiles and still have to userequire. Migrating all tests to TS would be a very massive change, so it will be done gradually in follow-up PRs.After merging this PR, a slight (<1%) difference in code coverage may be caused by testing original sources vs. compiled+source maps, and using
ts-nodeinstead of regularnode.