Adjust useDatabricksOAuthInAzure behavior#225
Merged
kravets-levko merged 2 commits intomainfrom Feb 5, 2024
Merged
Conversation
kravets-levko
requested review from
andrefurlan-db,
arikfr,
rcypher-databricks,
superdupershant and
yunbodeng-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
force-pushed
the
adjust-useDatabricksOAuthInAzure-behaviour
branch
from
0559a98 to
d1ce0c7
Compare
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 90.61% 90.61%
=======================================
Files 62 62
Lines 1439 1439
Branches 246 246
=======================================
Hits 1304 1304
Misses 84 84
Partials 51 51 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
force-pushed
the
adjust-useDatabricksOAuthInAzure-behaviour
branch
from
d1ce0c7 to
f53b654
Compare
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
rcypher-databricks
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useDatabricksOAuthInAzure = truemeans that user wants to use Databricks OAuth method on given Azure instance. And if that Azure host is not supported - we shouldn't silently fall back to Azure OAuth but throw an error instead. Azure OAuth should be used only whenuseDatabricksOAuthInAzure = false