fixed #13660 - SuppressionList::Suppression::checked was not properly set in all cases#7380
Merged
firewave merged 5 commits intodanmar:mainfrom Apr 7, 2025
Merged
Conversation
Collaborator
Author
|
I will address the TODOs at a later date. I want to finally get #3090 merged first. |
firewave
force-pushed
the
suppr-wildcard-unmatched
branch
3 times, most recently
from
02c3b71 to
33c4ab7
Compare
This was referenced Mar 20, 2025
firewave
force-pushed
the
suppr-wildcard-unmatched
branch
from
33c4ab7 to
79233ae
Compare
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
suppr-wildcard-unmatched
branch
7 times, most recently
from
6b1a993 to
8ab2303
Compare
firewave
commented
Mar 21, 2025
firewave
force-pushed
the
suppr-wildcard-unmatched
branch
3 times, most recently
from
046ca45 to
8acd26e
Compare
danmar
reviewed
Apr 3, 2025
danmar
reviewed
Apr 7, 2025
lib/suppressions.h
Outdated
| bool thisAndNextLine{}; // Special case for backwards compatibility: { // cppcheck-suppress something | ||
| bool matched{}; | ||
| bool checked{}; // for inline suppressions, checked or not | ||
| bool checked{}; |
Owner
There was a problem hiding this comment.
could you add comments that explain "checked" and "matched".
Spontanously I guess "checked" just means that isSuppressed has been called at all? It does not say if the checkers has been executed or not?
And "matched" indicates if some warning was suppressed by this suppression?
Collaborator
Author
There was a problem hiding this comment.
bool matched{}; /** This suppression was fully matched in an isSuppressed() call */
bool checked{}; /** This suppression applied to code which was being analyzed but did not match the error in an isSuppressed() call */
danmar
approved these changes
Apr 7, 2025
Owner
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
if you add the comments for matched and checked then feel free to merge..
firewave
force-pushed
the
suppr-wildcard-unmatched
branch
from
8acd26e to
bc6b15d
Compare
…ly set in all cases
…ressed()` is never called
…teSuppressionState()`
firewave
force-pushed
the
suppr-wildcard-unmatched
branch
from
bc6b15d to
1154562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was initially introduced for inline suppressions but was actually used beyond that.