CppCheck: removed changing of debugwarnings for non-accepted files#4965
Merged
firewave merged 1 commit intodanmar:mainfrom Apr 28, 2023
Merged
CppCheck: removed changing of debugwarnings for non-accepted files#4965firewave merged 1 commit intodanmar:mainfrom
debugwarnings for non-accepted files#4965firewave merged 1 commit intodanmar:mainfrom
Conversation
Collaborator
Author
|
This also resolves a minor hot spot that is caused by the I tried to mitigate that in #4681 which hasn't been merged yet but getting rid of the call is obviously even better. |
chrchr-github
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in 9a10270 and it doesn't really make sense IMO.
It will also be the last write usage of the settings after #4964 is done and allows us to make the settings const and eliminate a copy which is a minor hot spot when using
ThreadExecutorand will enable us to use the shared Executor code in all cases without performance regressions.