Ticket #5373: delete can match %type% in C (take #2)#257
Merged
danmar merged 1 commit intodanmar:masterfrom Mar 9, 2014
Merged
Ticket #5373: delete can match %type% in C (take #2)#257danmar merged 1 commit intodanmar:masterfrom
danmar merged 1 commit intodanmar:masterfrom
Conversation
…le to properly handle %type% in Token::Match with "delete"
Contributor
Author
|
The forked process will get the same value as the forking process, but both will have their own life cycle as they're fully independent. But anyway, with threads they're truly shared, and we have an issue on Windows that uses threads and not processes. Should we therefore go back to my initial proposal in PR#248? |
Owner
|
ok.
In PR#248 every token has a pointer to tokenizer. This is excessive since Token is only interested to know if the code is cpp. Can the pointer tokenizer in #248 be changed to a bool isCPP instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is an alternative to PR#248 that implements the suggestion to add a flag to Token to know whether we're processing a C++ file or not. Thanks to consider pulling.
Cheers,
Simon