donate_cpu_lib: Fix python 3 crash if fail to get package#2445
Merged
danmar merged 2 commits intodanmar:masterfrom Dec 12, 2019
Merged
Conversation
Decoding a string is not allowed in python 3 (in python 2 it works). If fetching the package fails, assign an empty byte string instead to avoid crashing.
rikardfalkeborn
commented
Dec 12, 2019
Contributor
Author
rikardfalkeborn
left a comment
rikardfalkeborn
left a comment
There was a problem hiding this comment.
Hmm, this should just initialize package to b'' at line 132 instead.
Owner
|
sounds good. |
rikardfalkeborn
deleted the
donate_cpu_lib-fix-python-3-crash-if-fail-to-get-package
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a string is not allowed in python 3 (in python 2 it works).
If fetching the package fails, assign an empty byte string instead to
avoid crashing.
When this happes, previously there was a crash of the running script.
Now it will cause
donate_cpudo wait 30 seconds before retrying, whiletest-my-prwill exit cleanly. I saw this when trying to runtest-my-pr(more than once), probably due to shaky connection, perhaps
test-my-prshould also wait and retry at least a couple of times before exiting?