Allow RequestConfig and HttpClientContext to be injected#375
Merged
dakrone merged 1 commit intodakrone:masterfrom May 24, 2017
Merged
Conversation
Owner
|
This looks great, thanks @EvanHahn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the
RequestConfigandHttpClientContextinstances to be overridden.It is done like so:
We thinks this allows for more flexibility. In our case, it helps us do some fancier things with proxies. We want to set an
AuthCacheon ourHttpClientContextinstance, which looks something like this:This seems like it would also help solve #307 and allow SOCKS authentication to be provided, and perhaps help with #225.
Feedback is welcome, especially on some of the naming and spying done in the new test.