Explained how to get started for Ember projects built with Embroider#410
Open
ijlee2 wants to merge 1 commit intocss-modules:masterfrom
Open
Explained how to get started for Ember projects built with Embroider#410ijlee2 wants to merge 1 commit intocss-modules:masterfrom
ijlee2 wants to merge 1 commit intocss-modules:masterfrom
Conversation
… Ember projects built with Embroider
|
review pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Hello. In #379,
ember-css-moduleswas provided as a solution for introducing CSS modules to Ember projects.This library has indeed been the go-to library for years, but is currently known to be incompatible with Ember projects built with Embroider on the strictest settings. I believe, this year and next, more Ember teams will incrementally migrate their projects to use Embroider.
What changed?
I updated the
get-startedpage so that, under Ember, it also listsembroider-css-modulesas a solution.This project takes the approach of using plugins from the wider JavaScript community to implement CSS modules. Through CI, it is shown to be compatible with Embroider on the strictest settings.