Relax specification for argcomplete dependency#680
Relax specification for argcomplete dependency#680woile merged 1 commit intocommitizen-tools:masterfrom jakob-keller:argcomplete
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
+ Coverage 98.02% 98.08% +0.05%
==========================================
Files 40 40
Lines 1719 1720 +1
==========================================
+ Hits 1685 1687 +2
+ Misses 34 33 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks for this @jakob-keller, @woile. 🙇 I guess this will be in the next release within a few weeks judging from the release cadence here. In general, argcomplete seems to follow semver, would it make sense to relax this to v2 entirely? Not sure if it was intentional in 92b1e89 to restrict minor versions. This sometimes gets installed in environments along with other dependencies so just to reduce the number of times we get conflicts. |
I agree. My intention here was to relax the restriction without questioning the generally restrictive way dependencies are specified in this repo. But this would be a great request, i.e. a separate issue IMO. |
|
Thanks @jakob-keller. I've opened #683, feel free to chime in :) |
Description
Similar to #589
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Allow for installation of argcomplete 2.1.x in commitizen enabled projects
Steps to Test This Pull Request
Additional context