X Tutup
Skip to content

Add search to sidebar#215

Merged
robonetphy merged 49 commits intomainfrom
feat/sidebar-search
Oct 13, 2022
Merged

Add search to sidebar#215
robonetphy merged 49 commits intomainfrom
feat/sidebar-search

Conversation

@robonetphy
Copy link
Member

resolve #175

@robonetphy robonetphy marked this pull request as draft July 20, 2022 07:28
@robonetphy robonetphy marked this pull request as ready for review July 23, 2022 19:28
@robonetphy robonetphy requested a review from neSpecc September 1, 2022 17:02
@HyTekCoop HyTekCoop self-requested a review September 22, 2022 07:47
@HyTekCoop
Copy link
Contributor

I checked. Bugs were not found. There are a lot of comments and almost everything is clear, but of course I would like someone other than me to take a look at the code itself

Copy link
Contributor

@HyTekCoop HyTekCoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth changing the keyboard shortcut for search to mac, because command + p is the functionality for printing

@neSpecc

This comment was marked as resolved.

@neSpecc

This comment was marked as resolved.

@robonetphy robonetphy requested a review from neSpecc October 12, 2022 17:50
@robonetphy robonetphy requested a review from neSpecc October 12, 2022 18:40
@neSpecc

This comment was marked as resolved.

@robonetphy robonetphy requested a review from neSpecc October 12, 2022 19:48
@neSpecc

This comment was marked as resolved.

@robonetphy robonetphy merged commit 698c09c into main Oct 13, 2022
@nikmel2803 nikmel2803 deleted the feat/sidebar-search branch December 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: implement a search

3 participants

X Tutup