X Tutup
Skip to content

Commit f2e89fd

Browse files
Remove obsolete InputOutputStream transport, now that the Stream transport is implemented
1 parent 50ee405 commit f2e89fd

File tree

5 files changed

+1
-112
lines changed

5 files changed

+1
-112
lines changed

src/Microsoft.AspNetCore.NodeServices/Configuration.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ public static INodeServices CreateNodeServices(NodeServicesOptions options)
4141
return new HttpNodeInstance(options.ProjectPath, /* port */ 0, watchFileExtensions);
4242
case NodeHostingModel.Socket:
4343
return new SocketNodeInstance(options.ProjectPath, watchFileExtensions);
44-
case NodeHostingModel.InputOutputStream:
45-
return new InputOutputStreamNodeInstance(options.ProjectPath);
4644
default:
4745
throw new ArgumentException("Unknown hosting model: " + options.HostingModel);
4846
}

src/Microsoft.AspNetCore.NodeServices/Content/Node/entrypoint-stream.js

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/Microsoft.AspNetCore.NodeServices/HostingModels/InputOutputStreamNodeInstance.cs

Lines changed: 0 additions & 75 deletions
This file was deleted.

src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,13 @@ public OutOfProcessNodeInstance(string entryPointScript, string projectPath, str
2727
_projectPath = projectPath;
2828
_commandLineArguments = commandLineArguments ?? string.Empty;
2929
}
30-
30+
3131
public string CommandLineArguments
3232
{
3333
get { return _commandLineArguments; }
3434
set { _commandLineArguments = value; }
3535
}
3636

37-
protected Process NodeProcess
38-
{
39-
get
40-
{
41-
// This is only exposed to support the unreliable InputOutputStreamNodeInstance, which is just to verify that
42-
// other hosting/transport mechanisms are possible. This shouldn't really be exposed, and will be removed.
43-
return this._nodeProcess;
44-
}
45-
}
46-
4737
public Task<T> Invoke<T>(string moduleName, params object[] args)
4838
=> InvokeExport<T>(moduleName, null, args);
4939

src/Microsoft.AspNetCore.NodeServices/NodeHostingModel.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ namespace Microsoft.AspNetCore.NodeServices
33
public enum NodeHostingModel
44
{
55
Http,
6-
InputOutputStream,
76
Socket,
87
}
98
}

0 commit comments

Comments
 (0)
X Tutup