X Tutup
Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Some refactoring II#65

Closed
fozbek wants to merge 1 commit intocoder:masterfrom
fozbek:master
Closed

Some refactoring II#65
fozbek wants to merge 1 commit intocoder:masterfrom
fozbek:master

Conversation

@fozbek
Copy link
Copy Markdown

@fozbek fozbek commented Apr 25, 2019

No description provided.

Copy link
Copy Markdown
Collaborator

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for contributing! The codebase has been refactored a bit since you submitted this so I'd advise rebasing off the latest master

return host, dir
}

func createCommand(sshCmd *exec.Cmd, sshCmdStr string) *exec.Cmd {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function appears to be unused

return sshCmd
}

func syncConfigurations(sshFlags *string, host string) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if someone wished to sync from the remote back to the local machine?

@sreya sreya mentioned this pull request Apr 30, 2019
@fozbek fozbek closed this Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup