fix(e2e): retry login on transient network errors#22878
Open
fix(e2e): retry login on transient network errors#22878
Conversation
The login API call can fail with ERR_NETWORK_CHANGED during parallel e2e test execution. When this happens the page stays on /login and shows an error alert instead of redirecting to /workspaces. Race the expected redirect against the error alert appearing. If the sign-in fails, retry the form submission once before the final assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login API call can fail with
ERR_NETWORK_CHANGEDduring parallel e2e test execution. When this happens the page stays on/loginand shows an error alert instead of redirecting to/workspaces.After clicking Sign In, race the expected redirect against the error alert appearing. If the sign-in fails, retry the form submission once before the final
expectUrlassertion. This follows the same pattern used byreloadPageIfDynamicImportFailedfor handling dynamic import errors.