fix(site): prevent vertical scrollbar caused by deployment banner#22877
Open
tracyjohnsonux wants to merge 1 commit intomainfrom
Open
fix(site): prevent vertical scrollbar caused by deployment banner#22877tracyjohnsonux wants to merge 1 commit intomainfrom
tracyjohnsonux wants to merge 1 commit intomainfrom
Conversation
When the deployment banner's horizontal scrollbar appears (on narrow viewports), the scrollbar track height causes the page to exceed 100vh, triggering a vertical scrollbar. This is exacerbated by the global scrollbar-gutter: stable rule on <html> which reserves space for the vertical scrollbar. Adding overflow-y: hidden to the banner prevents vertical overflow from contributing to the document height when the horizontal scrollbar is rendered.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
Note, the agent was unable to show me a broken before, then a fixed after. So I wasn't able to confirm this would indeed fix things. Seems pretty straight forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the deployment banner's horizontal scrollbar appears on narrow viewports, it triggers an unwanted vertical scrollbar on the page.
Root Cause
The app sets
scrollbar-gutter: stableon<html>(inindex.css) which reserves space for a vertical scrollbar. TheDashboardLayoutusesmin-h-screenwithjustify-between, making content fill exactly 100vh. When the deployment banner'soverflow-x: autoactivates a horizontal scrollbar, the scrollbar track adds height that pushes the document past 100vh, triggering the vertical scrollbar.Fix
Add
overflow-y-hiddento the deployment banner. This prevents the horizontal scrollbar's track height from contributing to the document's vertical overflow.Changes
DeploymentBannerView.tsx: Addedoverflow-y-hiddenalongside existingoverflow-x-auto