fix(agent/reaper): prevent SIGINT from killing test process#22870
Draft
fix(agent/reaper): prevent SIGINT from killing test process#22870
Conversation
The TestReapInterrupt test sends SIGINT to its own process. Under the race detector, the catchSignals goroutine inside ForkReap may not have registered signal.Notify yet, so Go's default SIGINT handler can terminate the test binary. Register signal.Notify for os.Interrupt in the test before sending SIGINT. This disables the default termination behavior while still allowing the catchSignals handler to receive the signal independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TestReapInterrupttest sends SIGINT to its own process. Under the race detector, thecatchSignalsgoroutine insideForkReapmay not have registeredsignal.Notifyyet, so Go's default SIGINT handler can terminate the test binary withsignal: interrupt.Fix: register
signal.Notifyforos.Interruptin the test before sending SIGINT. This disables the default termination behavior while still allowing thecatchSignalshandler to receive the signal independently.