fix(agent): handle ignored errors in agentproc and filefinder#22853
Open
fix(agent): handle ignored errors in agentproc and filefinder#22853
Conversation
mafredri
force-pushed
the
fix/errcheck-agent
branch
from
8b4bad7 to
52d99b5
Compare
Log a warning when filepath.Walk fails during recursive directory watching instead of silently discarding the error.
mafredri
force-pushed
the
fix/errcheck-agent
branch
from
52d99b5 to
3b2a3be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle errors that were previously assigned to blank identifiers in the
agent/package tree.Changes
cmd.Wait()error at debug level. The error is expected after cancellation but should be visible for diagnostics.filepath.Walkerrors at warning level instead of silently discarding them. This is best-effort directory walking, so a warning is appropriate.Part of the effort to enable
errcheck.check-blankin golangci-lint.🤖 This PR was created with the help of Coder Agents, and reviewed by a human 🏂🏻.