fix(cli): handle ignored errors in ssh and scaletest commands#22852
Merged
fix(cli): handle ignored errors in ssh and scaletest commands#22852
Conversation
- ssh.go: Log ExistsViaCoderConnect DNS lookup error at debug level instead of silently discarding it. Fallthrough behavior preserved. - exp_scaletest_llmmock.go: Log srv.Stop() error via the existing logger instead of discarding it.
mafredri
force-pushed
the
fix/errcheck-cli
branch
from
2cf97bb to
740c2ab
Compare
ethanndickson
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle errors that were previously assigned to blank identifiers in the
cli/package.Changes
ExistsViaCoderConnectDNS lookup error at debug level instead of silently discarding it. Fallthrough behavior (treating failure as "not exists") is preserved, but failures are now visible in debug logs.srv.Stop()error via the existing logger instead of discarding it.Part of the effort to enable
errcheck.check-blankin golangci-lint.🤖 This PR was created with the help of Coder Agents, and reviewed by a human 🏂🏻.