fix(scaletest): handle ignored errors in llmmock and bridge#22850
Open
fix(scaletest): handle ignored errors in llmmock and bridge#22850
Conversation
mafredri
force-pushed
the
fix/errcheck-scaletest
branch
from
1a303df to
ad09a54
Compare
Surface the io.ReadAll error in the error message when an HTTP request fails with a non-200 status, instead of silently discarding it.
mafredri
force-pushed
the
fix/errcheck-scaletest
branch
from
ad09a54 to
a5126d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle errors that were previously assigned to blank identifiers in the
scaletest/package tree.Changes
llmmock/server.go (13 fixes)
json.Marshalfailure, log the error.bridge/run.go
io.ReadAllerror in the fallback body string instead of silently discarding it, so callers get useful error information about failed HTTP responses.Part of the effort to enable
errcheck.check-blankin golangci-lint.🤖 This PR was created with the help of Coder Agents, and reviewed by a human 🏂🏻.