fix: show accurate error message when startup script fails instead of misleading "agents not connected"#22843
Open
blinkagent[bot] wants to merge 2 commits intomainfrom
Open
fix: show accurate error message when startup script fails instead of misleading "agents not connected"#22843blinkagent[bot] wants to merge 2 commits intomainfrom
blinkagent[bot] wants to merge 2 commits intomainfrom
Conversation
… misleading "agents not connected" When a startup script fails (exits with non-zero code), the UI was displaying a misleading "Workspace agents are not connected" error even though the agent is actually connected and functional (SSH works, web terminal works). This change updates the UnhealthyWorkspaceAlert component to check agent lifecycle_state in addition to connection status, so it can distinguish between: - Agent disconnection issues - Agent connection timeouts - Agent shutdown states - Startup script failures (now shows "Startup script failed") Also fixes the double period bug in the alert description. Fixes #21946
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #21946
When a startup script fails (exits with non-zero code), the UI displayed a misleading "Workspace agents are not connected" error even though the agent is actually connected and functional (SSH works, web terminal works).
Changes
Updated the
UnhealthyWorkspaceAlertcomponent inWorkspace.tsxto check agentlifecycle_statein addition to connection status. The component now distinguishes between:This ensures users see actionable, accurate messaging instead of the alarming (and incorrect) disconnection error when the real problem is just a failing startup script.
Additional fixes
varwithletfor better scoping{" "}+.concatenation patternScreenshot context
Before: User sees "Workspace agents are not connected" even though agent IS connected
After: User sees "Startup script failed" with guidance to check agent logs