fix: avoid derp-related panic during wsproxy registration (backport release/2.30)#22343
Merged
f0ssel merged 1 commit intorelease/2.30from Mar 3, 2026
Merged
fix: avoid derp-related panic during wsproxy registration (backport release/2.30)#22343f0ssel merged 1 commit intorelease/2.30from
f0ssel merged 1 commit intorelease/2.30from
Conversation
If the primary had DERP disabled, workspace proxy registrations would fail with a panic, as the registration endpoint would attempt to access the mesh key from the nil DerpServer. Changes the endpoint to query the database for the key.
Contributor
Documentation CheckNo Changes NeededThis is a backport of #22322 — a pure internal bug fix that prevents a nil pointer panic when workspace proxies attempt to register with a Coder server that has the built-in DERP server disabled (
No user-facing behavior changes, new CLI flags, API changes, or configuration options are introduced. Automated review via Coder Tasks |
rowansmithau
added
the
cherry-pick/v2.30
Member
deansheather
left a comment
deansheather
left a comment
There was a problem hiding this comment.
LGTM. Checks are ❌ because the branch has a funky name and is trying to trigger the deploy workflow, but it's NBD
f0ssel
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22322.