chore: move Shared Workspaces from experiments to beta by zenithwolf1000 · Pull Request #22206 · coder/coder

zenithwolf1000 · 2026-02-20T02:06:58Z

Removed the shared-workspaces experiment and cleaned up related middleware
Added beta tagging to the UI for shared workspaces

…ions

…ce functions" This reverts commit 5a31660.

…ions

…itasks.go

github-actions · 2026-02-20T06:51:00Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

aslilac

pardon the large number of comments, they're all just small things. seems good overall.

aslilac · 2026-02-20T19:59:50Z

cli/list_test.go

@@ -108,7 +108,6 @@ func TestList(t *testing.T) {
 		var (
 			client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{


client, db = coderdtest.NewWithDatabase(t, nil)

this can be simplified a bit further. we don't need to pass an empty DeploymentValues, and without that we don't need to pass an empty Options either.

aslilac · 2026-02-20T19:59:58Z

cli/sharing_test.go

@@ -27,7 +27,6 @@ func TestSharingShare(t *testing.T) {
 		var (
 			client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{


aslilac · 2026-02-20T20:00:03Z

cli/sharing_test.go

@@ -70,7 +69,6 @@ func TestSharingShare(t *testing.T) {
 		var (
 			client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{


aslilac · 2026-02-20T20:00:08Z

cli/sharing_test.go

@@ -129,7 +127,6 @@ func TestSharingShare(t *testing.T) {
 		var (
 			client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{


aslilac · 2026-02-20T20:00:17Z

cli/sharing_test.go

@@ -184,7 +181,6 @@ func TestSharingStatus(t *testing.T) {
 		var (
 			client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{


there are a lot of these, you get the point

Shoot totally thought I cleaned these up, thanks! Will clean em.

aslilac · 2026-02-20T20:04:19Z

enterprise/cli/sharing_test.go

@@ -86,7 +85,6 @@ func TestSharingShare(t *testing.T) {
 			client, db, orgOwner = coderdenttest.NewWithDatabase(t, &coderdenttest.Options{
 				Options: &coderdtest.Options{


aslilac · 2026-02-20T20:04:45Z

enterprise/cli/sharing_test.go

@@ -142,7 +140,6 @@ func TestSharingShare(t *testing.T) {
 				client, db, orgOwner = coderdenttest.NewWithDatabase(t, &coderdenttest.Options{
 					Options: &coderdtest.Options{


same here and the next three similar things

aslilac · 2026-02-20T20:04:58Z

enterprise/coderd/workspaces_test.go


 		dv := coderdtest.DeploymentValues(t)
-		dv.Experiments = []string{string(codersdk.ExperimentWorkspaceSharing)}
+


Suggested change

aslilac · 2026-02-20T20:05:03Z

enterprise/coderd/workspaces_test.go


 		dv := coderdtest.DeploymentValues(t)
-		dv.Experiments = []string{string(codersdk.ExperimentWorkspaceSharing)}
+


Suggested change

aslilac · 2026-02-20T20:06:06Z

site/src/pages/OrganizationSettingsPage/OrganizationSettingsPageView.tsx

+							<span className="flex items-center gap-2">
+								Workspace Sharing
+								<FeatureStageBadge contentType="beta" size="sm" />
+							</span>


Suggested change

<span className="flex items-center gap-2">

Workspace Sharing

<FeatureStageBadge contentType="beta" size="sm" />

</span>

<div className="flex items-center gap-2">

Workspace Sharing

<FeatureStageBadge contentType="beta" size="sm" />

</div>

using span as a block is frowned upon

Remove empty DeploymentValues callbacks from workspace ACL tests in coderd/workspaces_test.go. These were left over from the workspace-sharing experiment removal and should be replaced with nil for cleaner test setup. Changes: - TestDeleteWorkspaceACL/WorkspaceOwnerCanDelete - TestDeleteWorkspaceACL/SharedUsersCannot - TestWorkspaceReadCanListACL

coder-tasks · 2026-02-20T21:32:44Z

Documentation Check

Updates Needed

docs/manifest.json - The shared-workspaces.md entry has "state": ["early access"] but should be "state": ["beta"] to match the PR's intent of promoting this feature from experiment to beta
codersdk/deployment.go (source for auto-generated docs/reference/cli/server.md) - The --disable-workspace-sharing flag description still says "requires the 'workspace-sharing' experiment to be enabled" but that experiment no longer exists after this PR; the description should be updated to remove that parenthetical

Automated review via Coder Tasks

Per PR review feedback, remove empty DeploymentValues callbacks and the Options structs that only contained them. When Options becomes empty, pass nil instead for cleaner test setup. Changes: - cli/sharing_test.go: Simplified 6 test cases - enterprise/cli/sharing_test.go: Removed empty Options from 6 test cases This completes the cleanup from removing the workspace-sharing experiment flag.

Remove outdated experiment messaging from the --disable-workspace-sharing flag description. The workspace sharing feature is now in beta and no longer requires an experiment flag to be enabled. Changed: - Removed "(requires the 'workspace-sharing' experiment to be enabled)" from the flag description

Address remaining review comments from PR #22206: 1. cli/list_test.go: Simplify empty Options to nil - Remove empty DeploymentValues callback wrapper 2. OrganizationSettingsPageView.tsx: Change span to div for title - Replace inline span with div for block-level flex container - Using span as a block element is frowned upon

Moving Shared Workspaces out of experiments -> beta

6d60604

github-actions bot assigned zenithwolf1000 Feb 20, 2026

zenithwolf1000 changed the title ~~Moving Shared Workspaces out of experiments -> beta~~ chore: move Shared Workspaces out of experiments -> beta Feb 20, 2026

Merge branch 'main' into sp/sw-beta

7e8c284

zenithwolf1000 changed the title ~~chore: move Shared Workspaces out of experiments -> beta~~ chore: move Shared Workspaces from experiments to beta Feb 20, 2026

zenithwolf1000 requested a review from aslilac February 20, 2026 02:08

docs: update workspaceACL comment to reflect beta status

9e6ff73

zenithwolf1000 force-pushed the sp/sw-beta branch from 2e3a502 to 9e6ff73 Compare February 20, 2026 06:13

zenithwolf1000 added 4 commits February 19, 2026 22:15

refactor: remove unused experiments param from convertWorkspace funct…

5a31660

…ions

Revert "refactor: remove unused experiments param from convertWorkspa…

65c4210

…ce functions" This reverts commit 5a31660.

refactor: remove unused experiments param from convertWorkspace funct…

fd84ad5

…ions

refactor: remove experiments param from convertWorkspace callers in a…

71dd5fa

…itasks.go

lints and things

7b30d09

zenithwolf1000 force-pushed the sp/sw-beta branch from 9557de9 to 7b30d09 Compare February 20, 2026 06:57

More lint fixes

1dd61be

zenithwolf1000 marked this pull request as ready for review February 20, 2026 18:30

aslilac approved these changes Feb 20, 2026

View reviewed changes

zenithwolf1000 added 5 commits February 20, 2026 13:35

moving shared workspaces to beta in docs

8368d47

make gen

0458958

zenithwolf1000 merged commit 37a8e61 into main Feb 23, 2026
52 of 54 checks passed

zenithwolf1000 deleted the sp/sw-beta branch February 23, 2026 16:30

github-actions bot locked and limited conversation to collaborators Feb 23, 2026

		@@ -108,7 +108,6 @@ func TestList(t *testing.T) {
		var (
		client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{

		@@ -27,7 +27,6 @@ func TestSharingShare(t *testing.T) {
		var (
		client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{

		@@ -70,7 +69,6 @@ func TestSharingShare(t *testing.T) {
		var (
		client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{

		@@ -129,7 +127,6 @@ func TestSharingShare(t *testing.T) {
		var (
		client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{

		@@ -184,7 +181,6 @@ func TestSharingStatus(t *testing.T) {
		var (
		client, db = coderdtest.NewWithDatabase(t, &coderdtest.Options{

		@@ -86,7 +85,6 @@ func TestSharingShare(t *testing.T) {
		client, db, orgOwner = coderdenttest.NewWithDatabase(t, &coderdenttest.Options{
		Options: &coderdtest.Options{

		@@ -142,7 +140,6 @@ func TestSharingShare(t *testing.T) {
		client, db, orgOwner = coderdenttest.NewWithDatabase(t, &coderdenttest.Options{
		Options: &coderdtest.Options{


		dv := coderdtest.DeploymentValues(t)
		dv.Experiments = []string{string(codersdk.ExperimentWorkspaceSharing)}

Conversation

zenithwolf1000 commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aslilac left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coder-tasks bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation Check

Updates Needed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Feb 20, 2026 •

edited

Loading

coder-tasks bot commented Feb 20, 2026 •

edited

Loading