fix(site): show when secret deployment options are configured#22151
Merged
jeremyruppel merged 1 commit intomainfrom Feb 20, 2026
Merged
fix(site): show when secret deployment options are configured#22151jeremyruppel merged 1 commit intomainfrom
jeremyruppel merged 1 commit intomainfrom
Conversation
Previously, when secret deployment options like CODER_OIDC_CLIENT_SECRET were populated, the API correctly returned the "secret": "true" annotation, but the UI did not indicate that these secrets were configured. The UI would show "Not set" regardless of whether the secret was set or not. Now, the UI checks both the secret annotation and the value_source field. When a secret is configured (value_source is set), it displays "Set" to indicate the secret is populated. When a secret is not configured, it displays "Not set". Fixes #18913 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jeremyruppel
requested review from
DanielleMaywood,
aslilac,
jaaydenh and
jakehwll
aslilac
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when secret deployment options like CODER_OIDC_CLIENT_SECRET were populated, the API correctly returned the "secret": "true" annotation, but the UI did not indicate that these secrets were configured. The UI would show "Not set" regardless of whether the secret was set or not.
Now, the UI checks both the secret annotation and the value_source field. When a secret is configured (value_source is set), it displays "Set" to indicate the secret is populated. When a secret is not configured, it displays "Not set".
Fixes #18913