Merged
Conversation
… dies (#21583)" This reverts commit f799cba. @deansheather reported that this breaks ControlMaster. Investigating alternative fixes to coder/internal#1217
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previously introduced parent-process monitoring for coder ssh --stdio, restoring prior behavior due to reported breakage with SSH ControlMaster.
Changes:
- Removes parent PID polling/cancelation logic for
--stdiomode fromcli/ssh.go. - Removes the hidden
--test.force-ppidflag used to simulate parent PID exit behavior. - Deletes the associated integration/unit tests that asserted stdio exit-on-parent-death behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cli/ssh.go |
Reverts stdio parent-death monitoring, removes the test-only flag, and deletes watchParentContext. |
cli/ssh_test.go |
Removes the integration test covering stdio exit when the parent process dies. |
cli/ssh_internal_test.go |
Removes unit tests for watchParentContext (function removed in revert). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deansheather
approved these changes
Feb 9, 2026
johnstcn
changed the title
ethanndickson
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#1217
This reverts commit f799cba.
@deansheather reported that this breaks ControlMaster.
Investigating alternative fixes to coder/internal#1217