fix: enable strict mode for swagger generation & upgrade swag#21975
Merged
fix: enable strict mode for swagger generation & upgrade swag#21975
Conversation
The upstream swag CLI (v1.16.2) does not expose a --strict flag, so warnings about duplicate routes are silently ignored (exit code 0). With Strict mode, duplicate @router declarations become hard errors instead of silent overwrites. This adds a Go wrapper (scripts/apidocgen/swaginit/main.go) that calls the swag gen.Build() API directly with Strict: true, and updates generate.sh to use it instead of 'go tool swag init'.
Notable improvements: - Better generics support (map params, function-scoped types) - More precise numeric format annotations (float64, int64) - x-enum-descriptions for richer API docs - json:omitempty marks fields as optional - Security fix for CVE-2024-45338 (x/net) - Swagger output now uses spaces instead of tabs
mtojek
changed the title
johnstcn
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Go wrapper (
scripts/apidocgen/swaginit/main.go) that calls swag's Go API withStrict: true. The--strictflag isn't available in swag's CLI in any version, so the wrapper is the only way to enable it.Also upgrades swag from v1.16.2 to v1.16.6 (better generics support, precise numeric formats,
x-enum-descriptions, CVE-2024-45338 fix).