X Tutup
Skip to content

fix: set content-primary text color instead of hardcoding white text#21908

Merged
aqandrew merged 4 commits intomainfrom
aqandrew/no-hardcoded-white-text
Feb 5, 2026
Merged

fix: set content-primary text color instead of hardcoding white text#21908
aqandrew merged 4 commits intomainfrom
aqandrew/no-hardcoded-white-text

Conversation

@aqandrew
Copy link
Contributor

@aqandrew aqandrew commented Feb 4, 2026

Copy link
Contributor

@coder-tasks coder-tasks bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Reviewed the migration from hardcoded text-white to semantic text-content-primary token. The changes are well-structured and address the issue correctly. Found 1 minor spacing inconsistency.

Summary

  • ✅ All 4 instances of .text-white properly replaced with text-content-primary
  • ✅ Changes verified in Storybook stories
  • ✅ Follows Tailwind best practice of using semantic color tokens
  • ⚠️ One minor formatting inconsistency with double spaces

Testing

Good job verifying the changes in Storybook. The affected components (Markdown GFM alerts, TaskPrompt external auth, UserGroupsCell tooltips, and Workspace notifications) should all now properly respect the theme's primary content color.

@aqandrew aqandrew merged commit 62fa0e8 into main Feb 5, 2026
31 checks passed
@aqandrew aqandrew deleted the aqandrew/no-hardcoded-white-text branch February 5, 2026 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: workspace notification heading is unreadable in light theme

3 participants

X Tutup