fix: set content-primary text color instead of hardcoding white text#21908
Merged
fix: set content-primary text color instead of hardcoding white text#21908
Conversation
Contributor
There was a problem hiding this comment.
Code Review
Reviewed the migration from hardcoded text-white to semantic text-content-primary token. The changes are well-structured and address the issue correctly. Found 1 minor spacing inconsistency.
Summary
- ✅ All 4 instances of
.text-whiteproperly replaced withtext-content-primary - ✅ Changes verified in Storybook stories
- ✅ Follows Tailwind best practice of using semantic color tokens
⚠️ One minor formatting inconsistency with double spaces
Testing
Good job verifying the changes in Storybook. The affected components (Markdown GFM alerts, TaskPrompt external auth, UserGroupsCell tooltips, and Workspace notifications) should all now properly respect the theme's primary content color.
DanielleMaywood
approved these changes
Feb 4, 2026
aslilac
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21735
Removes all instances of
.text-whitefrom the codebase.Storybook stories where I verified these fixes:
MarkdownGfmAlertExternalAuthButtonsUserGroupsCellNotifications