Conversation
Justification:
- Populating `members` is authorized with `group_member.read`
which is not required to be able to share a workspace
- Populating `total_member_count` is authorized with `group.read`
which is required to be able to share
- The updated helper is only used in template/workspace sharing UIs,
so other pages that might need counts of readable members are
unaffected
Related to: coder/internal#1302
geokat
deleted the
geokat/internal-1302-groups-with-zero-members-when-sharing-workspace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification:
Populating
membersis authorized withgroup_member.readwhich is not required to be able to share a workspacePopulating
total_member_countis authorized withgroup.readwhich is required to be able to shareThe updated helper is only used in template/workspace sharing UIs, so other pages that might need counts of readable members are unaffected
Related to: coder/internal#1302