X Tutup
Skip to content

Use VS Code packaging for releases#7721

Merged
code-asher merged 3 commits intomainfrom
asher/module-cleanup
Mar 28, 2026
Merged

Use VS Code packaging for releases#7721
code-asher merged 3 commits intomainfrom
asher/module-cleanup

Conversation

@code-asher
Copy link
Copy Markdown
Member

See commits for more info.

For the NPM package (and tests, at least for now), we will still use
linux-x64, but this is going to allow using the platform build targets
for our standalone releases so we can avoid having to copy all the
packaging steps (like cleaning up modules).

This does mean that the NPM package when installed will be missing those
cleanup steps.  Possibly we can try to break out the packaging step into
a something that can be ran standalone (which will also require
installing dev dependencies like gulp) but not sure how much work this
would be.
To avoid having to install them again.

Also moved an env block to the root of the  job.
@code-asher code-asher requested a review from a team as a code owner March 27, 2026 22:03
@code-asher code-asher force-pushed the asher/module-cleanup branch 6 times, most recently from 3f23659 to cf6248c Compare March 28, 2026 00:13
Instead of building the linux-x64 package, stripping the modules, then
installing them again, we build the correct target and use the modules
as they are.

This means we do not have to copy all the post-processing steps like the
ones that delete unnecessary modules.

For the NPM package we still publish the linux-x64 package (without
modules of course).  This means npm installations do not get that same
post-processing.

Another advantage of this is that we can run the release immediately
without having to wait for the build step, or on a commit that no longer
has a build artifact, since they all build individually now.  We could
try sharing the core-ci build step, but leaving that alone for now.

I also converted the macOS jobs into a matrix.

Deleted the CI readme because it was out of date and seemed to just
repeat what should be described in the scripts anyway.

Removed a section about Homebrew since we do not maintain that anymore.

It looks like there is no need to symlink node_modules.asar anymore.
@code-asher code-asher force-pushed the asher/module-cleanup branch from cf6248c to 2d08e6e Compare March 28, 2026 00:15
@code-asher code-asher merged commit b5611ef into main Mar 28, 2026
16 of 17 checks passed
@code-asher code-asher deleted the asher/module-cleanup branch March 28, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

X Tutup