Conversation
|
Ping @code-asher – https://github.com/coder/code-server/actions/runs/23541856157/job/68531271657?pr=7716#step:11:461 |
The target we have been using has started throwing all sorts of errors during the build (even without any of our patches). After checking the VS Code repo I think these are the ones we should actually be using. They are way faster, too.
code-asher
force-pushed
the
code-1.113.0
branch
from
d61f67d to
01734df
Compare
There was a problem hiding this comment.
I took a look at VS Code's GitHub workflows and it looks like they are using different build targets, so I tried those and it seems to be working.
Also these targets are way, way faster. 7.5-10 minutes instead of the hour+ it was before. Almost worried something must be wrong haha but I smoke tested it and everything seems to be working. Will probably make this one an RC first just in case.
Good idea. |
|
@code-asher Please note the size increase, e.g.
|
|
Aha yup I noticed that too and investigated. They are including a few new dependencies, The rest appears to be new files and source maps, but most of it seems to be those Copilot dependencies. |
|
I think actually we can strip some of that out, looking at how VS Code is building things. I will mess around with that tomorrow. |
2 participants
No description provided.