[GH-459] explicitly create a volume and set permission for project dir#471
[GH-459] explicitly create a volume and set permission for project dir#471kylecarbs merged 1 commit intocoder:masterfrom sr229:docker-volumes
Conversation
…oject dir Signed-off-by: Kibo Hikari <enra@sayonika.moe>
nhooyr
left a comment
nhooyr
left a comment
There was a problem hiding this comment.
seems reasonable otherwise
| # We create first instead of just using WORKDIR as when WORKDIR creates, the user is root. | ||
| RUN mkdir -p /home/coder/project | ||
| RUN mkdir -p /home/coder/project && \ | ||
| chmod g+rw /home/coder/project; |
There was a problem hiding this comment.
I need to set the R/W permissions explicitly because I found out on OpenShift hosts, if this is not set, the container would outright crash.
A good supporting evidence of this is OpenShift scrambling UIDs and GIDs, which screws with permissions a little. This is designed to allow you to write there even if you don't own it.
There was a problem hiding this comment.
Still not clear why this is necessary. You shouldn't be able to write if you don't own it, that is correct behaviour. I'm going to revert this @kylecarbs
There was a problem hiding this comment.
container would outright crash <-- still a little concerned about the possibility of reintroducing this behavior with a revert.
There was a problem hiding this comment.
container would outright crash <-- still a little concerned about the possibility of reintroducing this possibility with a revert.
Not a concern, don't worry. Its definitely not outright crashing, there is a permission related issue.
There was a problem hiding this comment.
@multishifties I explained it already becuase of how OpenShift handles UIDs and GIDs, which would make /home/coder/project inaccessible practically on the official image. So I guess this would make sense if they revert it, but the official image will never work on OpenShift due to missing permissions
There was a problem hiding this comment.
becuase of how OpenShift handles UIDs and GIDs,
What does that mean? How does it handle it?
You're not being clear with your concerns, I can't give you a good response.
|
CC @nhooyr, what do you think |
|
LGTM |
…oject dir (#471) Signed-off-by: Kibo Hikari <enra@sayonika.moe>
4 participants
Describe in detail the problem you had and how this PR fixes it
This ensures a emptydir volume if the user forgot to mount. This allows OpenShift compatibility and solves
Docker issues.
Is there an open issue you can link to?
This fixes #459 and #469 partially