PreTasks: If timezone fetch fails, revert to fallback timezones.

desimaniac · desimaniac · commit 3463334ab92a · 2019-05-27T15:16:05.000-05:00
diff --git a/roles/pre_tasks/tasks/subtasks/variables.yml b/roles/pre_tasks/tasks/subtasks/variables.yml
@@ -148,13 +148,71 @@
         )
       else false }}"
 
-- name: Variables | Fetch time zone
-  uri:
-    url: http://ip-api.com/line?fields=timezone
-    return_content: yes
-  register: timezone_response
-  when: (system.timezone|lower == 'auto') or (not system.timezone)
-
-- name: Variables | Set time zone variable
+- name: Variables | Check if 'system.timezone' was specified
   set_fact:
-    tz: "{{ (timezone_response.content | trim) if ((system.timezone|lower == 'auto') or (not system.timezone)) else (system.timezone) }}"
+    system_timezone_specified: "{{ true if not (
+        (system is undefined)
+        or
+        (system is none)
+        or
+        (system | trim | length == 0)
+        or
+        (system.timezone is undefined)
+        or
+        (system.timezone is none)
+        or
+        (system.timezone | trim | length == 0)
+        or
+        (system.timezone | lower == 'auto')
+      )
+      else false }}"
+
+- name: Variables | Set 'tz' variable to custom timezone
+  set_fact:
+    tz: "{{ system.timezone }}"
+  when: (system_timezone_specified)
+
+- name: Variables | Auto timezone tasks
+  block:
+
+  - name: Variables | Get time zone from 'http://ip-api.com'
+    uri:
+      url: http://ip-api.com/line?fields=timezone
+      return_content: yes
+    register: ip_api_timezone_response
+    ignore_errors: yes
+
+  - name: Variables | Set 'tz' variable from 'http://ip-api.com'
+    set_fact:
+      tz: "{{ ip_api_timezone_response.content | trim }}"
+    when: (ip_api_timezone_response is succeeded)
+
+  - name: Variables | Get timezone from local machine
+    block:
+
+    - name: Variables | Check to see if '/etc/timezone' exists
+      stat:
+        path: /etc/timezone
+      register: etc_timezone
+
+    - name: Variables | Set timezone from local machine
+      block:
+
+      - name: Variables | Get info from '/etc/timezone'
+        shell: cat /etc/timezone
+        register: etc_timezone_contents
+
+      - name: Variables | Set 'tz' variable to '/etc/timezone'
+        set_fact:
+          tz: "{{ etc_timezone_contents.stdout | trim }}"
+
+      when: (etc_timezone.stat.exists and etc_timezone.stat.isreg)
+
+    - name: Variables | Set 'tz' variable to fallback value of 'Etc/UTC'
+      set_fact:
+        tz: "Etc/UTC"
+      when: not (etc_timezone.stat.exists and etc_timezone.stat.isreg)
+
+    when: (ip_api_timezone_response is failed)
+
+  when: (not system_timezone_specified)
