X Tutup
Skip to content

Update core.clj#94

Closed
zendevil wants to merge 1 commit intoclojure:masterfrom
zendevil:patch-1
Closed

Update core.clj#94
zendevil wants to merge 1 commit intoclojure:masterfrom
zendevil:patch-1

Conversation

@zendevil
Copy link
Copy Markdown

10x speed in accessing vectors with get-in

10x speed in accessing vectors with get-in
@borkdude
Copy link
Copy Markdown
Contributor

@zendevil The clojure contribution process doesn't work through Github PRs.

Besides this, I think your implementation is wrong. Did you run the tests? E.g. this is incorrectly returning nil in your implementation:

(get-in [{:a 1}] [0 :a])

@puredanger Perhaps it's good to set up a PR template that explains this, as it occurs quite often that people still post PRs here.

@zendevil
Copy link
Copy Markdown
Author

zendevil commented Jun 20, 2021

You're right about the incorrect behavior of this version of get-in, but it does pass all the tests in the master branch.

@puredanger
Copy link
Copy Markdown
Member

For Clojure issues, please ask questions at https://ask.clojure.org. If you'd like to contribute patches, further see the process at https://clojure.org/dev/dev#_becoming_a_contributor

@puredanger puredanger closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup