update core.clj - clarify docs for reduce function#88
Closed
dheerajbhaskar wants to merge 1 commit intoclojure:masterfrom
Closed
update core.clj - clarify docs for reduce function#88dheerajbhaskar wants to merge 1 commit intoclojure:masterfrom
dheerajbhaskar wants to merge 1 commit intoclojure:masterfrom
Conversation
Reduce function has two scenarios. It was not coming through in the docs. The formatting was updated for readability and to make sure these two scenarios came through easily to the reader
Contributor
|
Clojure does not take PRs from Github. Maybe @puredanger can add a PR template :). |
Contributor
|
I believe the current recommendation is to create a new question on ask.clojure.org, and if changes to Clojure seem desirable, someone like Alex Miller will create an ticket for it. |
Contributor
|
Right. I meant a PR template for communicate that Github is not the preferred place for this. |
|
@borkdude how do we generally do it then for Clojure? It's odd that it looks like the codebase essentially hasnt been updated since June -- where are our commits going to? |
Contributor
|
@briancabbott Clojure, the language, isn't that fast moving. Read more about contributing to clojure here: |
Member
|
Updated CONTRIBUTING.md and added PULL_REQUEST_TEMPLATE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce function has two scenarios. It was not coming through in the docs. The formatting was updated for readability and to make sure these two scenarios came through easily to the reader