Closed
Conversation
Contributor
|
Someone should close this than. |
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Feb 2, 2016
…TE/josh-android:master to master
Squashed commit of the following:
commit 777b80ce2b46ba3f28db8041a0a285e33039cd52
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Fri Sep 12 15:25:35 2014 -0700
udpated gradle to use test res
commit d4092562a077dbe2c3f9a471e43f9a7b05a08766
Merge: 71d5f20 b8eb732
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Fri Sep 12 22:23:58 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit 'b8eb73268be5e122775e7fa82e7a8415609199a6':
fixed scouting delete
scouting fix
commit 71d5f209bced297a2d1d393f22397c1eb1f92c4a
Merge: 36774a5 3c318d5
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Thu Sep 11 22:41:08 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit '3c318d5c90998459b2463fb99e0d191fad34f649':
Merge pull request clojure#17 in MOB/climate-android from ~CSTUEHRENBERG/climate-android:master to master
added code for fixing update scouting
commit 36774a52a326a0baac0746df252c5eda2fe90d41
Merge: 79b5657 e5f845f
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Thu Sep 11 17:30:29 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit 'e5f845f242fdc19c844601124a47103964f053ec':
Merge pull request clojure#16 in MOB/climate-android from ~JMUSSELWHITE/josh-android:release/1.3 to release/1.3
commit 79b5657249e830bbc535c808d8a6a02b029962cf
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Thu Sep 11 10:05:18 2014 -0700
map test consolidation
commit 67aa159e3ad039af4b2c6e2694356defb2f41a51
Merge: 586a520 9b46015
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Thu Sep 11 17:04:04 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit '9b4601584a795840815beb40d98ad57a3fba6a1a':
Merge pull request clojure#14 in MOB/climate-android from ~CSTUEHRENBERG/climate-android:master to master
Incremented version
commit 586a520d721c59a7e5186e9120ea6d57c54f6b26
Merge: f0cee81 3d01293
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Tue Sep 9 23:39:06 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit '3d012936a15290e1bc6a664ad4486e024607bc99':
Merge pull request clojure#13 in MOB/climate-android from ~JMUSSELWHITE/josh-android:master to master
commit f0cee814cc9a80cfaf38ef6334e85f83f692a8cd
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Tue Sep 9 16:37:57 2014 -0700
added returning to list after a scouting submit
commit 433c4a0dd89f05593c5bff9db774e638d48a182e
Merge: b1a99bf 108b943
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Tue Sep 9 21:59:23 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit '108b943a0abe39b0c05247e3b4a2fcb9f2c81123':
Merge pull request clojure#12 in MOB/climate-android from ~JMUSSELWHITE/josh-android:master to master
commit b1a99bfb7736d92bbecaa27652f50b375513bdf4
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Tue Sep 9 14:58:33 2014 -0700
added deleting of scouting event
commit c072e5241e776041a41fb68e7ec1abffa3cf4822
Merge: 7446fa4 f6ae870
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Tue Sep 9 21:54:52 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit 'f6ae8700fcf286023c4186250ddc0ab2b2b85b22':
Merge pull request clojure#11 in MOB/climate-android from ~JMUSSELWHITE/josh-android:master to master
commit 7446fa48d55b6c27af16702e4235a938da4db7e5
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Tue Sep 9 14:53:21 2014 -0700
updated scouting for pics and refactored code
commit 8909d2298520d03e2381af6f11d6a34b50cf5b10
Merge: acda078 305156d
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Tue Sep 9 00:36:17 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit '305156de80a9f4cc22f3c504b6f9864092e6a64c':
Merge pull request clojure#10 in MOB/climate-android from ~JMUSSELWHITE/josh-android:master to master
commit acda0781dbedb1607d69201a119c44c5afcdebad
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Mon Sep 8 17:35:27 2014 -0700
added test for imageviewer
commit 489e17858e6351785a2cfe07ee66b406873492b7
Merge: 975f03c e37df5c
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Mon Sep 8 23:59:47 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit 'e37df5cf58e4cedcc38c3eaf769c92684e92ac20':
Merge pull request clojure#9 in MOB/climate-android from ~JMUSSELWHITE/josh-android:master to master
commit 975f03c2a184aeb39e2550d5a1d2ce5ecd4fc9d5
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Mon Sep 8 16:58:43 2014 -0700
added image viewer for scouting
commit b783efdfe95bb8c40d5fe6ffed80e9bdb3fd5252
Merge: c7e20ad 2597440
Author: Joshua Musselwhite <jmusselwhite@climate.com>
Date: Sat Sep 6 00:17:39 2014 +0000
Merging in latest from upstream (MOB/climate-android:refs/heads/master)
* commit '2597440bd31c195f298f5795832260361844e964':
Merge pull request clojure#8 in MOB/climate-android from ~JMUSSELWHITE/josh-android:master to master
Merge pull request clojure#7 in MOB/climate-android from ~JMUSSELWHITE/josh-android:master to master
commit c7e20ad22c700c30c570611c03e04e2f0cabdd83
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Fri Sep 5 15:12:52 2014 -0700
added test for MultipleField selectors
commit fe0eebcd44428d5ad99cc8c599a7d3c69d7ed0b5
Author: Musselwhizzle <jm@therealjoshua.com>
Date: Fri Sep 5 14:09:08 2014 -0700
fixed future radar bug. added tests for it
cursor bot
pushed a commit
to The-Alchemist/cloffle-clojure
that referenced
this pull request
Mar 28, 2026
New tests cover: - Step-into named function reports callee source (clojure#13) - Step-into multi-arity function (clojure#14) - Breakpoint on call expression line with StatementTag (clojure#15) - Three breakpoints fire in order on separate def forms (clojure#16) - Step-into then step-over stays in callee body (clojure#17) - Step-into then step-out returns to caller (clojure#18) - Step-into anonymous fn created with fn form (clojure#19) - Breakpoint inside multi-line function body (clojure#20) - Step-into higher-order function call (clojure#21) - Recursive stack depth monotonically increases (clojure#22) - Step-out from function returns to caller (clojure#23) - Breakpoint on if branch fires (clojure#24) - Breakpoint on let binding fires (clojure#25) - Step-into closure that captures locals (clojure#26) - Breakpoint in loop body fires on each iteration (clojure#27) - Source section at call site has correct characters (clojure#28) - Breakpoint inside do body (clojure#29) - Step-into across separate eval contexts (clojure#30) - Breakpoint with cond macro expansion (clojure#31) - Multiple step-into follows b->c call chain (clojure#32) All 737 JUnit tests pass. Co-authored-by: karl <karl@medplum.com>
The-Alchemist
added a commit
to The-Alchemist/cloffle-clojure
that referenced
this pull request
Mar 29, 2026
…agation (#6) * Improve debugger support: RootTag on FnDispatchNode, source section propagation, language reference on FnNode Key changes: - FnDispatchNode now reports RootTag alongside RootBodyTag, enabling the Truffle debugger to recognize function entry boundaries for step-into - FnDispatchNode gets its source section from the parent FnNode so that isInstrumentable() returns true - FnNode stores a language reference (set by ExprToNode) and uses it as primary source in getCallTarget(), falling back to Clojure.getContext() lookup. This ensures per-function ClojureRootNode instances are created with a proper language association for stack frame reporting. - InvokeNode propagates source sections to FnDispatchNode when creating static call targets - truffleEval() now sets source sections and root names on eagerly executed form roots - SequentialFormNode per-form roots now set source sections properly (full source first, then narrow when form section is available) - 8 new debugger tests (20 total, all passing) covering function name reporting, multi-line fn breakpoints, step-over, recursive stack growth, step-out, source section propagation, and eager eval roots - All 725 JUnit tests pass Co-authored-by: karl <karl@medplum.com> * Update CLOFFLE_NOTES.md with debugger improvements documentation Document the FnDispatchNode RootTag fix, source section propagation, language reference on FnNode, truffleEval source sections, and SequentialFormNode narrowing. Update known limitations to reflect current state. Co-authored-by: karl <karl@medplum.com> * Add StatementTag to hasTag on remaining call node classes InstanceCallNode, ProtocolInvokeNode, NewNode, NativeCallNode, and KeywordInvokeNode now report StandardTags.StatementTag alongside CallTag and ExpressionTag for instrumentation consistency. Co-authored-by: karl <karl@medplum.com> * Remove unnecessary @TruffleBoundary, add StatementTag to call nodes, restructure SequentialFormNode Major debugger improvements: - SequentialFormNode: Removed @TruffleBoundary from executeSequentially() and restructured to use @children DirectCallNode[] created at parse time. Per-form roots are now created in the constructor with proper source section narrowing (full source first, adoptChildren(), then narrow). This allows the debugger to step between top-level forms and enables breakpoints to match nodes inside per-form roots. - InvokeNode, GenericStaticCallNode: Added StatementTag alongside CallTag and ExpressionTag. Breakpoints default to matching StatementTag, so call expressions were previously invisible to line breakpoints. - ClojureNode: Removed @TruffleBoundary from getSourceSection() - this is metadata computation that doesn't need a compilation boundary. - ClojureTypes: Removed @TruffleBoundary from castDouble() - trivial cast. - Updated DebuggerTest: stepIntoFromCallSite now asserts 2 suspensions (step-into actually enters the called function body). Updated test comments. - All 725 JUnit tests pass. Co-authored-by: karl <karl@medplum.com> * Update CLOFFLE_NOTES.md: document StatementTag on call nodes, SequentialFormNode restructure, boundary removals Co-authored-by: karl <karl@medplum.com> * Add 20 new debugger tests (32 total) New tests cover: - Step-into named function reports callee source (clojure#13) - Step-into multi-arity function (clojure#14) - Breakpoint on call expression line with StatementTag (clojure#15) - Three breakpoints fire in order on separate def forms (clojure#16) - Step-into then step-over stays in callee body (clojure#17) - Step-into then step-out returns to caller (clojure#18) - Step-into anonymous fn created with fn form (clojure#19) - Breakpoint inside multi-line function body (clojure#20) - Step-into higher-order function call (clojure#21) - Recursive stack depth monotonically increases (clojure#22) - Step-out from function returns to caller (clojure#23) - Breakpoint on if branch fires (clojure#24) - Breakpoint on let binding fires (clojure#25) - Step-into closure that captures locals (clojure#26) - Breakpoint in loop body fires on each iteration (clojure#27) - Source section at call site has correct characters (clojure#28) - Breakpoint inside do body (clojure#29) - Step-into across separate eval contexts (clojure#30) - Breakpoint with cond macro expansion (clojure#31) - Multiple step-into follows b->c call chain (clojure#32) All 737 JUnit tests pass. Co-authored-by: karl <karl@medplum.com> * Add 20 more debugger tests (52 total) New tests cover: - Step-over does not enter callee (clojure#33) - Breakpoint inside try body (clojure#34) - Step-into variadic function (clojure#35) - Breakpoint on case form (clojure#36) - Breakpoint on throw form (clojure#37) - Breakpoint on recur form fires each iteration (clojure#38) - Source file name at breakpoint is correct (clojure#39) - Step-into locally-defined function (let + fn) (clojure#40) - Breakpoint on nested let (clojure#41) - Breakpoint removal prevents further hits (clojure#42) - Breakpoint on keyword invoke (:key map) (clojure#43) - Breakpoint inside letfn with mutual recursion (clojure#44) - Breakpoint on Java interop .method call (clojure#45) - Breakpoint on constructor call (clojure#46) - Breakpoint on static method call (clojure#47) - Step-into multi-arity with delegating arity (clojure#48) - Continue after multiple breakpoints resumes fully (clojure#49) - Breakpoint on and/or macro expansion (clojure#50) - Source section length matches form length (clojure#51) - Breakpoint on when macro (clojure#52) All 757 JUnit tests pass. Co-authored-by: karl <karl@medplum.com> * Add 18 advanced debugger tests (70 total) Advanced debugger feature tests: - Conditional breakpoint fires on loop iterations (clojure#53) - One-shot breakpoint fires exactly once (clojure#54) - Breakpoint ignoreCount skips initial hits (clojure#55) - Breakpoint hit count tracks total activations (clojure#56) - DebugStackFrame.getScope() returns local variable scope (clojure#57) - DebugStackFrame.getLanguage() returns cloffle language info (clojure#58) - Internal frames not visible in default mode (clojure#59) - SuspendedEvent.getSuspendAnchor() returns BEFORE (clojure#60) - Return value available after step-over (clojure#61) - Breakpoint isResolved after execution (clojure#62) - Breakpoint enable/disable toggle (clojure#63) - SuspendedEvent.getBreakpoints() reports the firing breakpoint (clojure#64) - Step-into count > 1 steps multiple times (clojure#65) - Step-over count > 1 skips multiple statements (clojure#66) - isBreakpointHit() vs isStep() distinction (clojure#67) - Breakpoint on function in different source fires on call (clojure#68) - Breakpoint on defn line fires during definition (clojure#69) - Eval expression in suspended frame context (clojure#70) All 775 JUnit tests pass. Co-authored-by: karl <karl@medplum.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a mistype fix.