Fix #103: incorrect error with if-let#1
Closed
jszakmeister wants to merge 1 commit intoclojure:masterfrom
jszakmeister:master
Closed
Fix #103: incorrect error with if-let#1jszakmeister wants to merge 1 commit intoclojure:masterfrom jszakmeister:master
jszakmeister wants to merge 1 commit intoclojure:masterfrom
jszakmeister:master
Conversation
Contributor
Author
|
I'm going to submit this through the tracker. |
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Apr 27, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Apr 27, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Apr 27, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Apr 27, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Apr 27, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Apr 27, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
May 23, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
May 24, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Jun 9, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
bronsa
pushed a commit
to bronsa/clojure
that referenced
this pull request
Jun 14, 2013
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jun 23, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jun 29, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jun 30, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jul 5, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jul 6, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jul 7, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jul 8, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jul 10, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jul 15, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Jul 31, 2015
This solves two issues as specified by #CLJ-1134. Issue clojure#1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue clojure#2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not.
stuarthalloway
pushed a commit
that referenced
this pull request
Jul 31, 2015
This solves two issues as specified by #CLJ-1134. Issue #1 is solved by doing a relative jump forward within `absolute-reposition` in cl_format.clj, line 114 by switching `(- (:pos navigator) position)` with `(- position (:pos navigator))`. Issue #2 is handled by changing the default `n`-parameter to `*` depending on whether the `@`-prefix is placed or not. If it is placed, then `n` defaults to 0, otherwise it defaults to 1. In addition, new tests have been appended to `test_cl_format.clj` to ensure the correctness of this patch. The tests have been tested on the Common Lisp implementation GNU CLISP 2.49, which presumably handle the `~n@*` correctly. This patch and GNU CLISP returns the same output for each format call, sans case for printed symbols; Common Lisp has case-insensitive symbols, whereas Clojure has not. Signed-off-by: Stuart Halloway <stu@cognitect.com>
amalloy
pushed a commit
to amalloy/clojure
that referenced
this pull request
Aug 7, 2015
Typed Locals
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Aug 12, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Aug 12, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Aug 18, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Aug 19, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Aug 24, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Aug 24, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 11, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 18, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 18, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 22, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 22, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 25, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 25, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 28, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Sep 28, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 2, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 2, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 6, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 6, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 12, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 12, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 13, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 13, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 14, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 14, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 15, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 15, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 27, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
MichaelBlume
pushed a commit
to MichaelBlume/clojure
that referenced
this pull request
Oct 27, 2015
The criteria for when a tail call is a safe point to clear 'this': 1) Must be in return position 2) Not in a try block (might need 'this' during catch/finally) 3) When not direct linked Return position (clojure#1) isn't simply context == C.RETURN because loop bodies are always parsed in C.RETURN context A new dynvar METHOD_RETURN_CONTEXT tracks whether an InvokeExpr in tail position can directly leave the body of the compiled java method. It is set to RT.T in the outermost parsing of a method body and invalidated (set to null) when a loop body is being parsed where the context for the loop expression is not RETURN parsed. Also, clear on StaticInvokeExpr now that they are a thing again
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My CA is in the mail, should be in Rich's hands any day now.