X Tutup
Skip to content

Command issue for Fedora and centos#9965

Closed
alasad311 wants to merge 1 commit intocli:trunkfrom
alasad311:patch-1
Closed

Command issue for Fedora and centos#9965
alasad311 wants to merge 1 commit intocli:trunkfrom
alasad311:patch-1

Conversation

@alasad311
Copy link
Copy Markdown

@alasad311 alasad311 commented Nov 26, 2024

Command change for fedora, centos where as its suppose to be --add-repo rather than addrepo --from-repofile=

Update install_linux.md
5ab76a2 
Command change for fedora, centos where as its suppose to be `--add-repo` rather than `addrepo --from-repofile=`
@alasad311 alasad311 requested a review from a team as a code owner November 26, 2024 16:09
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Nov 26, 2024
@cliAutomation
Copy link
Copy Markdown
Collaborator

cliAutomation commented Nov 26, 2024

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@BagToad
Copy link
Copy Markdown
Member

BagToad commented Nov 26, 2024

👋 Hey @alasad311

These instructions were updated recently to account for dnf5 now being the default: #9844

If you're using Fedora 39, you probably want to use our existing dnf4 commands, which have the syntax you're looking for:

cli/docs/install_linux.md

Lines 52 to 54 in 984bfdc

sudo dnf4 install 'dnf-command(config-manager)'
sudo dnf4 config-manager --add-repo https://cli.github.com/packages/rpm/gh-cli.repo
sudo dnf4 install gh --repo gh-cli

Please let me know if that works 😁

@BagToad
Copy link
Copy Markdown
Member

BagToad commented Nov 28, 2024

@alasad311 I'm going to close out this PR because I believe the solution is in my comment above. If I misunderstood, feel free to reach back out.

@BagToad BagToad closed this Nov 28, 2024
@BagToad BagToad mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williammartin williammartin Awaiting requested review from williammartin williammartin is a code owner automatically assigned from cli/code-reviewers

Assignees

No one assigned

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alasad311 @cliAutomation @BagToad
X Tutup