X Tutup
Skip to content

Add relevant metadata to pr view in CLI#748

Merged
vilmibm merged 12 commits intocli:masterfrom
doi-t:add-pr-metadata-to-view
Apr 9, 2020
Merged

Add relevant metadata to pr view in CLI#748
vilmibm merged 12 commits intocli:masterfrom
doi-t:add-pr-metadata-to-view

Conversation

@doi-t
Copy link
Copy Markdown
Contributor

@doi-t doi-t commented Apr 4, 2020

This PR is another part of #663 (pr view). #663 can be closed by #745 and this PR.

This is an example of PR metadata in a view (gh issue view 12 --repo doi-t/cli-test). The ground rule is basically the same as #745 which is guided by #663 (comment).

Screen Shot 2020-04-04 at 13 23 24

Reviewers is missing in this PR. I made another nested PR for Reviewers #762.

@doi-t doi-t mentioned this pull request Apr 7, 2020
3 tasks
@doi-t doi-t force-pushed the add-pr-metadata-to-view branch from cef525a to 531bfbc Compare April 8, 2020 11:07
@doi-t
Copy link
Copy Markdown
Contributor Author

doi-t commented Apr 8, 2020

This PR is ready for code review. I've removed Participants and the truncation following #663 (comment) (Technically, the truncation will happen if there are more than 100 items).

Screen Shot 2020-04-08 at 20 38 37

@doi-t doi-t marked this pull request as ready for review April 8, 2020 11:40
Copy link
Copy Markdown
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is still lingering code for Participants so once that's out I can merge; otherwise nice work!

@doi-t doi-t force-pushed the add-pr-metadata-to-view branch from 1aa8ce1 to 6d0e5bf Compare April 9, 2020 16:03
@doi-t
Copy link
Copy Markdown
Contributor Author

doi-t commented Apr 9, 2020

@vilmibm
I've removed all Participants related codes for pr view 6d0e5bf

@vilmibm
Copy link
Copy Markdown
Contributor

vilmibm commented Apr 9, 2020

rad, thank you!

@vilmibm vilmibm merged commit 3c33510 into cli:master Apr 9, 2020
@doi-t doi-t deleted the add-pr-metadata-to-view branch April 9, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup